fix: exit nonzero on wait timeout#165
Merged
Merged
Conversation
1f65aea to
d8c7ceb
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitreturn exit code11(WAIT_TIMEOUT) when a wait result times out.result.timedOut,matched, andcapturedAtSeq.--idle-ms/--exitwaits.docs/USAGE.mdand the README command-surface note for the new public CLI contract.Closes #151.
User-facing behavior
A timed-out standalone
waitnow exits non-zero while still emitting anok: trueresult envelope:This makes shell composition fail closed:
Validation
mise run ciwas run before the initial commit and again after rebasing onorigin/main; after the first PR CI surfaced stale integration expectations, the affected tests and the full integration suite were run locally before updating the PR branch.Dogfooding
Used an isolated absolute
AGENT_TTY_HOMEandnpx tsx src/cli/main.tsto create a live session, verify a successful render wait still exits0, and verify standalone render and--exittimeouts now exit11while preserving success envelopes.No visual UI changed; no screenshots or videos are included.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh